Skip to content

Change feature_id to feature-id in changelogs #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcawl merged 1 commit into from
Jan 6, 2026
Merged

Change feature_id to feature-id in changelogs #2421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/services/Elastic.Documentation.Services/Changelog/ChangelogData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information

using YamlDotNet.Serialization;

namespace Elastic.Documentation.Services.Changelog;

/// <summary>
Expand All @@ -22,6 +24,7 @@ public class ChangelogData
public string? Description { get; set; }
public string? Impact { get; set; }
public string? Action { get; set; }
[YamlMember(Alias = "feature-id", ApplyNamingConventions = false)]
public string? FeatureId { get; set; }
public bool? Highlight { get; set; }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Elastic.Documentation.Services.Tests/ChangelogServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ public async Task CreateChangelog_WithFeatureId_CreatesValidYaml()
Directory.CreateDirectory(outputDir);
var files = Directory.GetFiles(outputDir, "*.yaml");
var yamlContent = await File.ReadAllTextAsync(files[0], TestContext.Current.CancellationToken);
yamlContent.Should().Contain("feature_id: feature:new-search-api");
yamlContent.Should().Contain("feature-id: feature:new-search-api");
}
}

Loading