Skip to content

Remove CMD+Semicolon keyboard shortcut handling #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mpdreamz merged 1 commit into from
Jan 8, 2026
Merged

Remove CMD+Semicolon keyboard shortcut handling #2430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions src/Elastic.Documentation.Site/Assets/web-components/SearchOrAskAi/SearchOrAskAiButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import '../../eui-icons-cache'
import { NavigationSearch } from './NavigationSearch'
import {
ModalMode,
// ModalMode,
useModalActions,
useModalIsOpen,
useModalMode,
Expand Down Expand Up @@ -29,7 +29,11 @@ export const SearchOrAskAiButton = () => {
const { euiTheme } = useEuiTheme()
const isModalOpen = useModalIsOpen()
const modalMode = useModalMode()
const { openModal, closeModal, setModalMode } = useModalActions()
const {
// openModal,
closeModal,
// setModalMode
} = useModalActions()

const { data: isApiAvailable } = useQuery({
queryKey: ['api-health'],
Expand Down Expand Up @@ -58,14 +62,14 @@ export const SearchOrAskAiButton = () => {
padding: 2rem;
`

const openAndSetModalMode = (mode: ModalMode) => {
setModalMode(mode)
if (!isModalOpen) {
openModal()
}
}
// const openAndSetModalMode = (mode: ModalMode) => {
// setModalMode(mode)
// if (!isModalOpen) {
// openModal()
// }
// }

const openAskAiModal = () => openAndSetModalMode('askAi')
// const openAskAiModal = () => openAndSetModalMode('askAi')
// const openSearchModal = () => openAndSetModalMode('search')

// Prevent layout jump when hiding the scrollbar by compensating its width
Expand All @@ -81,14 +85,14 @@ export const SearchOrAskAiButton = () => {
// openSearchModal()
// }

if (
(event.metaKey || event.ctrlKey) &&
event.code === 'Semicolon'
) {
event.preventDefault()
openAskAiModal()
// Input focuses itself via its own Cmd+; listener
}
// if (
// (event.metaKey || event.ctrlKey) &&
// event.code === 'Semicolon'
// ) {
// event.preventDefault()
// openAskAiModal()
// // Input focuses itself via its own Cmd+; listener
// }
}
window.addEventListener('keydown', handleKeydown)
return () => {
Expand Down
Loading