Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure authoring test project reports properly on Github Actions #463

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Feb 10, 2025

There are two test engines in .NET core.

By default xunit3 will run under TestPlatform however that engine is not allowing --logger arguments so we can not see the github annotations for failed tests.

See: microsoft/testfx#4365 for more background about this missing feature. The author for TSUnit still has a few issues open to properly write extensions to support this.

So here we now run xunit3 under the old VSTest platform so we can run dotnet test as per default with the --logger argument.


image

This now also moves both projects over to xunit v3 so both test projects behave the same.

cc @elastic/dotnet

@Mpdreamz Mpdreamz added the chore label Feb 10, 2025
@Mpdreamz Mpdreamz changed the title [Do not merge] testing test reporting of new test project Ensure authoring test project reports properly on Github Actions Feb 10, 2025
@Mpdreamz Mpdreamz requested a review from reakaleek February 10, 2025 20:44
@Mpdreamz Mpdreamz merged commit cc07233 into main Feb 10, 2025
5 checks passed
@Mpdreamz Mpdreamz deleted the test/test-reporter branch February 10, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants