Assembler share single crosslink resolver over all the builds #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a shared cross-link resolver to optimize linking across builds in the Assembler project. Key changes include:
- Adding a new AssemblerCrossLinkFetcher class to handle cross-link fetching.
- Introducing a new "Skip" flag in Repository configurations via both code and YAML files.
- Updating AssemblerBuilder to utilize the shared CrossLinkResolver during the documentation building process.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/docs-assembler/Building/AssemblerCrossLinkFetcher.cs | New cross-link fetching class using shared configuration |
| src/docs-assembler/Configuration/Repository.cs | Adds a skip flag property to repository configuration |
| src/docs-assembler/assembler.yml | Updates reference configurations with skip flags |
| src/docs-assembler/Building/AssemblerBuilder.cs | Modifies build process to include the cross-link resolver |
cotti
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.