Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Edit This File" path #790

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Fix "Edit This File" path #790

merged 5 commits into from
Mar 20, 2025

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Mar 20, 2025

This issue had two facets.

The first one, which was reported previously, is that certain projects had broken links to edit their files on Github, particularly on local deployment.

However, upon digging further into the current state of this link, it was found that most links were also broken due to incorrect branch detection. The second facet is this - we should look for .git/config inside the project's root folder rather than its docs/ folder.

Fixes #769 and #310

cotti added 2 commits March 19, 2025 22:37
…than the docs subfolder.

Fixes detached branches being incorrectly inferred from not finding .git/config
@cotti cotti added the fix label Mar 20, 2025
@cotti cotti self-assigned this Mar 20, 2025
@cotti cotti marked this pull request as ready for review March 20, 2025 04:44
@cotti cotti requested a review from a team as a code owner March 20, 2025 04:44
@cotti cotti merged commit 65373d7 into main Mar 20, 2025
10 checks passed
@cotti cotti deleted the fix/edit_this_file_path branch March 20, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit this page links don't work on staging
3 participants