Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Includes GITHUB_PR_REF_NAME as a job-level environment variable. #799

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Includes GITHUB_PR_REF_NAME as a job-level environment variable. #799

merged 2 commits into from
Mar 20, 2025

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Mar 20, 2025

This variable was not being propagated in the workflow, causing the branch reference to fallback to main.

@cotti cotti added the fix label Mar 20, 2025
@cotti cotti requested a review from a team as a code owner March 20, 2025 12:14
reakaleek
reakaleek approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you please remove it from the step level?

Thank you 🙏

@cotti cotti merged commit 05d39f0 into main Mar 20, 2025
10 checks passed
@cotti cotti deleted the fix/workflow_github_pr_ref_name_hotfix branch March 20, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reakaleek reakaleek reakaleek approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cotti @reakaleek