Skip to content

Fix pages nav behaviour attempt 2 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
+2 −2
Merged

Fix pages nav behaviour attempt 2 #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Elastic.Markdown/Slices/Layout/_TocTreeNav.cshtml
View file
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@
<li class="flex group/li @(item.Depth == topLevelFile ? "font-semibold py-8 not-last:border-b-1 border-grey-20" : "ml-5 lg:ml-4 mt-4 lg:mt-3")">
<a
href="@f.Url"
@Htmx.GetHxAttributes(f.Url, !Model.IsPrimaryNavEnabled && f.RootNavigation.Id == Model.RootNavigationId)
@Htmx.GetHxAttributes(f.Url, Model.IsPrimaryNavEnabled && f.RootNavigation.Id == Model.RootNavigationId || true)
class="sidebar-link group-[.current]/li:text-blue-elastic!"
id="page-@id"
>
@@ -48,7 +48,7 @@
</label>
<a
href="@(g.Index?.Url ?? "")"
@Htmx.GetHxAttributes(g.Index?.Url ?? "", !Model.IsPrimaryNavEnabled || g.NavigationRootId == Model.RootNavigationId)
@Htmx.GetHxAttributes(g.Index?.Url ?? "", Model.IsPrimaryNavEnabled && g.NavigationRootId == Model.RootNavigationId || true)
id="page-@(g.Index?.Id ?? id)"
class="sidebar-link @(g.Depth == topLevelGroup ? "font-semibold font-sans mb-1 text-base" : "")">
@(g.Index?.NavigationTitle ?? "Untitled")

Unchanged files with check annotations Beta

View file
docs/development/index.md
TODO write development documentation here
![Image outside of scope](../images/great-drawing-of-new-structure.png)

Check notice on line 10 in docs/development/index.md

GitHub Actions / build 

Image '../images/great-drawing-of-new-structure.png' is referenced out of table of contents scope '/home/runner/work/docs-builder/docs-builder/docs/development'.
View file
docs/_docset.yml
project: 'doc-builder'

Check notice on line 1 in docs/_docset.yml

GitHub Actions / build 

Substitution key 'ece' is not used in any file

Check notice on line 1 in docs/_docset.yml

GitHub Actions / build 

Substitution key 'eck' is not used in any file
max_toc_depth: 2
# indicates this documentation set is not linkable by assembler.
# relaxes a few restrictions around toc building and file placement