Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor within details for non Chrome browsers #823

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Mar 24, 2025

Closes #757

@reakaleek reakaleek requested a review from a team as a code owner March 24, 2025 11:53
@reakaleek reakaleek self-assigned this Mar 24, 2025
@reakaleek reakaleek added the fix label Mar 24, 2025
@cotti
Copy link
Contributor

cotti commented Mar 24, 2025

I can still see the old behavior on Firefox:

firefox_uDjrXkXlEp.mp4

Control group on Chromium-based browser:

brave_VSSr1j24ql.mp4

@reakaleek
Copy link
Member Author

@cotti what version of firefox are you using?

What can I say. It works on my machine 😅

Screen.Recording.2025-03-24.at.22.42.05.mov

@cotti
Copy link
Contributor

cotti commented Mar 25, 2025

Of course it just updated here...

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG for me too

@reakaleek reakaleek merged commit f92cb41 into main Mar 25, 2025
10 checks passed
@reakaleek reakaleek deleted the feature/fix-anchor-within-details branch March 25, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safari/Firefox] Linking to anchors within drop-downs doesn't work properly
3 participants