Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer and fix landing page layout #824

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Add footer and fix landing page layout #824

merged 2 commits into from
Mar 24, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Mar 24, 2025

Closes #482

@reakaleek reakaleek requested a review from a team as a code owner March 24, 2025 12:49
@reakaleek reakaleek self-assigned this Mar 24, 2025
@cotti
Copy link
Contributor

cotti commented Mar 24, 2025

I was wondering about the darker section with the footer - if it'd be included for this issue.

The behavior here is to not let the left nav expand its height even when the actual content would allow it to, so it always has a scrollbar if there are enough items. Is it supposed to be like this?

@reakaleek reakaleek merged commit e6f7944 into main Mar 24, 2025
10 checks passed
@reakaleek reakaleek deleted the feature/footer branch March 24, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright notice: symbol missing, date incorrect
2 participants