GlobalNavigationPathProvider: change definition for the newRelativePath #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
Mar 25, 2025
| @@ -98,7 +98,11 @@ public GlobalNavigationPathProvider(GlobalNavigationFile navigationFile, Assembl | |||
| } | |||
|
|
|||
| var originalPath = Path.Combine(match.Host, match.AbsolutePath.Trim('/')).TrimStart('/'); | |||
| var newRelativePath = relativePath.AsSpan().TrimStart(originalPath).TrimStart('/').ToString(); | |||
| var relativePathSpan = relativePath.AsSpan(); | |||
There was a problem hiding this comment.
LGTM! We have a few misuses of TrimStart() on Span<T> 😢
Maybe as a follow up PR put this in a new extension method TrimStartExact() and update other places we misused TrimStart().
Mpdreamz
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830
The issue is a subtle behavior detail on
TrimStart()(andTrimEnd()). Rather than acting akin toSubstring(), it continues to try and remove more of the input being manipulated as long as a character belongs in the trim set, until it finds a character not belonging to it.Anyhow, the default behavior has been changed to verify if it starts with the originalPath, and if it does, perform a
Slice()instead.