-
Notifications
You must be signed in to change notification settings - Fork 61
Adds Delete Elastic Cloud on Kubernetes section #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Just minor comments (i'd like to double check one with @shainaraskas ).
After this review is complete I'd like to ping some devs for one of the topics I shared.
kubectl delete elasticsearch test-deployment | ||
``` | ||
|
||
This deletes the custom resource and all associated infrastructure, such as {{es}} nodes, services, and persistent data volumes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a note about different options (if any) to retain data when deleting an Elasticsearch cluster.
Let's finalize this review and afterwards we will ping devs to see if they believe there's anything helpful to add in terms of persistent data
options when deleting an Elasticsearch cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barkbay , or @pebrc : we are adding a short section in a doc to delete
an ECK managed deployment. Would you please review it and let us know if you think ECK (or storage classes) provide anything useful in relation with persistent data retention
that we could add in this part as a side note?
Otherwise we will be just saying that when deleting the Elasticsearch
resource, persistent data volumes will be deleted also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please review it and let us know if you think ECK (or storage classes) provide anything useful in relation with persistent data retention that we could add in this part as a side note?
There is a note here about preserving volumes when a cluster is deleted: https://github.com/elastic/docs-content/blob/main/deploy-manage/deploy/cloud-on-k8s/volume-claim-templates.md#controlling-volume-claim-deletion-k8s_controlling_volume_claim_deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've added a note about this based on the volume claim deletion guide. Let me know what you think @eedugon @barkbay and @shainaraskas .
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a minor word change proposal
Co-authored-by: Edu González de la Herrán <[email protected]>
Preview
This PR adds documentation for deleting an Elastic Cloud on Kubernetes (ECK) deployment to the Delete a cloud deployment page.
Related issue: https://github.com/elastic/docs-projects/issues/457