Skip to content

Adds Delete Elastic Cloud on Kubernetes section #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 14, 2025
Merged

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Apr 8, 2025

Preview

This PR adds documentation for deleting an Elastic Cloud on Kubernetes (ECK) deployment to the Delete a cloud deployment page.

Related issue: https://github.com/elastic/docs-projects/issues/457

@kosabogi kosabogi requested review from szabosteve and eedugon April 8, 2025 06:31
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Just minor comments (i'd like to double check one with @shainaraskas ).

After this review is complete I'd like to ping some devs for one of the topics I shared.

kubectl delete elasticsearch test-deployment
```

This deletes the custom resource and all associated infrastructure, such as {{es}} nodes, services, and persistent data volumes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note about different options (if any) to retain data when deleting an Elasticsearch cluster.
Let's finalize this review and afterwards we will ping devs to see if they believe there's anything helpful to add in terms of persistent data options when deleting an Elasticsearch cluster.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barkbay , or @pebrc : we are adding a short section in a doc to delete an ECK managed deployment. Would you please review it and let us know if you think ECK (or storage classes) provide anything useful in relation with persistent data retention that we could add in this part as a side note?

Otherwise we will be just saying that when deleting the Elasticsearch resource, persistent data volumes will be deleted also.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please review it and let us know if you think ECK (or storage classes) provide anything useful in relation with persistent data retention that we could add in this part as a side note?

There is a note here about preserving volumes when a cluster is deleted: https://github.com/elastic/docs-content/blob/main/deploy-manage/deploy/cloud-on-k8s/volume-claim-templates.md#controlling-volume-claim-deletion-k8s_controlling_volume_claim_deletion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've added a note about this based on the volume claim deletion guide. Let me know what you think @eedugon @barkbay and @shainaraskas .

@eedugon eedugon requested review from pebrc and barkbay April 9, 2025 09:21
@kosabogi kosabogi requested a review from eedugon April 14, 2025 07:25
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a minor word change proposal

@kosabogi kosabogi merged commit 2a396cb into main Apr 14, 2025
4 checks passed
@kosabogi kosabogi deleted the delete-eck-deployment branch April 14, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants