Skip to content

[observability] [apm] Document additional privileges for tail-based sampling #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2025

Conversation

colleenmcginnis
Copy link
Contributor

Closes elastic/observability-docs#4718

Documents the additional privileges needed when using tail-based sampling. This is just my initial attempt based on @bmorelli25's comment. @endorama can you take a look?

@colleenmcginnis colleenmcginnis requested a review from endorama April 9, 2025 17:23
@colleenmcginnis colleenmcginnis self-assigned this Apr 9, 2025
@endorama
Copy link
Member

@colleenmcginnis the technical side of this change is good. I'm not commenting on the language side as you are more knowledgeable than me. Overall the change looks clear and precise to me. Thanks for moving this forward!

@colleenmcginnis colleenmcginnis requested a review from a team April 10, 2025 18:35
@colleenmcginnis colleenmcginnis marked this pull request as ready for review April 10, 2025 18:53
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a lil wording suggestion if I'm understanding the sentence correctly. Otherwise, LGTM!

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) April 14, 2025 19:09
@colleenmcginnis colleenmcginnis merged commit 4bd47a0 into main Apr 14, 2025
3 of 4 checks passed
@colleenmcginnis colleenmcginnis deleted the observability-docs-4718 branch April 14, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Update APM secure communications with Elasticsearch
3 participants