Skip to content

Add streams docs #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 14, 2025
Merged

Add streams docs #1091

merged 24 commits into from
Apr 14, 2025

Conversation

mdbirnstiehl
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl commented Apr 10, 2025

This PR adds the first iteration of the Streams documentation.

@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review April 14, 2025 13:09
@mdbirnstiehl mdbirnstiehl requested a review from a team April 14, 2025 17:59
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦖

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick read through. Some thoughts below

Requires an LLM Connector to be configured.
Instead of writing the grok patterns by hand, you can use the **Generate Patterns** button to generate the patterns for you.

% TODO Elastic LLM?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan for this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure on this one. @LucaWintergerst are we saying we want to describe configuring the LLM in a future iteration?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we'll have an out of the box LLM soon that we should talk about here in the future

@mdbirnstiehl mdbirnstiehl merged commit 1cb60ed into elastic:main Apr 14, 2025
5 checks passed
@mdbirnstiehl mdbirnstiehl deleted the streams-docs branch April 14, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants