-
Notifications
You must be signed in to change notification settings - Fork 63
[DOCS] Opster Migration: Add errors to troubleshooting pages #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks @thekofimensah ! I'll review soon, FYI but these won't be for 9.0 because we don't want to inadvertently introduce build issues right before the release. also there are 92 build errors (?!) so we'll have to figure out what's up there ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (4)
troubleshoot/elasticsearch/unable-to-retrieve-node-fs-stats.md:10
- [nitpick] Consider removing or clarifying the placeholder comment to ensure the documentation is clear and professional.
# is mapped_pages needed for newly created docs?
troubleshoot/elasticsearch/security/token-expired.md:10
- [nitpick] Review whether the placeholder comment is necessary; if not, it could be removed to streamline the document.
# is mapped_pages needed for newly created docs?
troubleshoot/elasticsearch/security/invalid-token.md:10
- [nitpick] Consider removing the placeholder comment if it is not intended for the final documentation.
# is mapped_pages needed for newly created docs?
troubleshoot/elasticsearch/failed-to-parse-field-of-type.md:10
- [nitpick] Evaluate whether this placeholder comment should be removed to avoid potential confusion in the final documentation.
# is mapped_pages needed for newly created docs?
troubleshoot/elasticsearch/updating-number-of-replicas-to-for-indices.md
Outdated
Show resolved
Hide resolved
I merged in 'main' to fix these. review coming soon ⏳ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a first batch of comments -- more coming soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not done, but sending over another batch of suggestions
btw @thekofimensah , just want to make sure you're aware that every docs PR automatically gets a preview link: https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1116/troubleshoot/elasticsearch/ (look for environments/deployments in the PR history) This can help with things like figuring out whether to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another batch
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last batch for now. Thanks for working through all my suggestions!
troubleshoot/elasticsearch/updating-number-of-replicas-to-for-indices.md
Outdated
Show resolved
Hide resolved
troubleshoot/elasticsearch/updating-number-of-replicas-to-for-indices.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
… one. Other small changes as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more tweaks.
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but w/ one more grammar note. Thanks!
Errors
section in troubleshooting with specific errors insideAttempted to follow https://docs.elastic.dev/content-architecture/content-type/troubleshooting/error
Via discussion with @marciw , this section is still being organized so these may be moved around.