Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using glob in build_pr.sh #3182

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Test using glob in build_pr.sh #3182

merged 1 commit into from
Mar 4, 2025

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Mar 4, 2025

Test out using a glob pattern in build_pr.sh to determine when we should run the AsciiDoc preview build. If this works, it will be an imperfect solution because it would not build if only an image was updated in a PR, but that might be ok. 🤷

To test this we'll have to:

  1. Merge this PR
  2. Open a test PR in elastic/ecs-logging

Then come back here and update the other repos.

@bmorelli25 what do you think about this approach?

@colleenmcginnis colleenmcginnis self-assigned this Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review March 4, 2025 21:30
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner March 4, 2025 21:30
@colleenmcginnis colleenmcginnis enabled auto-merge (squash) March 4, 2025 21:45
@colleenmcginnis colleenmcginnis merged commit ca2f11c into master Mar 4, 2025
5 checks passed
@colleenmcginnis colleenmcginnis deleted the test-glob branch March 4, 2025 22:17
@colleenmcginnis
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants