Skip to content

[RFC 0053][Update] Stage2: New device fields #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2025
Merged

[RFC 0053][Update] Stage2: New device fields #2530

merged 3 commits into from
Sep 16, 2025
+746 −1

Conversation

ricardo-estc
Copy link
Contributor

This PR proposes changes on top of:

Added fields based on previous PR:

  • device.vendor.name
  • device.vendor.id
  • device.product.name
  • device.product.id
  • device.type

@ricardo-estc ricardo-estc requested a review from a team as a code owner September 12, 2025 11:04
@github-actions GitHub Actions
Copy link

Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2530/reference/

@github-actions GitHub Actions
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2025 •
edited
Loading

🔍 Preview links for changed docs

ricardo-estc
ricardo-estc commented Sep 12, 2025
View reviewed changes
trisch-me
trisch-me reviewed Sep 12, 2025
View reviewed changes
schemas/device.yml
level: extended
type: keyword
short: ProductID of the device
description: >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add also links to what exactly product ID is (as in phase 0 PR)
You should treat each description in a way that everyone, who wants to use this field, should understand how the field is generated (or what constraints it has)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so while short might be the same as in phase 0, description should elaborate more details on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trisch-me added proper description for each field.
Is it fine to include links to the microsoft documentation about vid and pid?
Their documentation is very well written

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

trisch-me
trisch-me reviewed Sep 15, 2025
View reviewed changes
trisch-me
trisch-me reviewed Sep 15, 2025
View reviewed changes
@ricardo-estc ricardo-estc requested a review from mjwolf September 15, 2025 14:27
@trisch-me
Copy link
Contributor

@mjwolf I will wait for your review before merge

@ricardo-estc ricardo-estc merged commit ee30e83 into main Sep 16, 2025
8 checks passed
@ferullo ferullo mentioned this pull request Sep 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwolf mjwolf mjwolf approved these changes

@trisch-me trisch-me trisch-me approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardo-estc @trisch-me @mjwolf