Skip to content

DRAFT: Added an updated version of notebook for video script #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justincastilla
Copy link
Contributor

@justincastilla justincastilla commented Jul 15, 2025

Updated the notebook to use modern mechanisms and API calls. I ONLY updated the notebook codebase, not the supporting text. I will change the copy at a later time

Copy link

gitnotebooks bot commented Jul 15, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/471

@carlyrichmond
Copy link
Contributor

@justincastilla I see you've added a new notebook rather than updated the existing one. Why is that? I would have expected us to update the existing notebook, especially if the plan is to update the piece as well.

Can you also double check if things are running as expected and using latest possible versions? I see an error in one of the cells in your updated notebook:

"\u001b[31mERROR: Could not find a version that satisfies the requirement torch==1.11 (from versions: 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.5.0, 2.5.1, 2.6.0, 2.7.0, 2.7.1)\u001b[0m\u001b[31m\n",
      "\u001b[0m\u001b[31mERROR: No matching distribution found for torch==1.11\u001b[0m\u001b[31m\n",
      "\u001b[0m\n",
      "\u001b[1m[\u001b[0m\u001b[34;49mnotice\u001b[0m\u001b[1;39;49m]\u001b[0m\u001b[39;49m A new release of pip is available: \u001b[0m\u001b[31;49m23.2.1\u001b[0m\u001b[39;49m -> \u001b[0m\u001b[32;49m25.1.1\u001b[0m\n",
      "\u001b[1m[\u001b[0m\u001b[34;49mnotice\u001b[0m\u001b[1;39;49m]\u001b[0m\u001b[39;49m To update, run: \u001b[0m\u001b[32;49mpython3 -m pip install --upgrade pip\u001b[0m\n",
      "Note: you may need to restart the kernel to use updated packages.\n"

@justincastilla
Copy link
Contributor Author

@justincastilla I see you've added a new notebook rather than updated the existing one. Why is that? I would have expected us to update the existing notebook, especially if the plan is to update the piece as well.

I'm not going to replace it fully until this new notebook is approved and ready. Also, we'll want it around until the article is updated, as it references the same code.

Can you also double check if things are running as expected and using latest possible versions? I see an error in one of the cells in your updated notebook:

The new code no longer needs those packages. It's been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants