ES|QL: Improve random query generation tests #121750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Apparently it's not time to enable this test yet #121754 |
…tests_202502' into esql/update_generative_tests_202502
luigidellaquila
changed the title
idegtiarenko
approved these changes
Feb 7, 2025
luigidellaquila
added
auto-backport
|
Thanks @idegtiarenko! |
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Feb 7, 2025
costin
reviewed
Feb 7, 2025
| return previousOutput.get(randomIntBetween(0, previousOutput.size() - 1)).name(); | ||
| // we need to exclude <all-fields-projected> | ||
| // https://github.com/elastic/elasticsearch/issues/121741 | ||
| return randomFrom(previousOutput.stream().filter(x -> x.name().equals("<all-fields-projected>") == false).toList()).name(); |
Comment on lines
+236
to
+241
| return col.type.equals("keyword") | ||
| || col.type.equals("text") | ||
| || col.type.equals("long") | ||
| || col.type.equals("integer") | ||
| || col.type.equals("ip") | ||
| || col.type.equals("version"); |
There was a problem hiding this comment.
put those types into a set and simply do a map.contains()
| } | ||
|
|
||
| private static boolean sortable(Column col) { | ||
| return col.type.equals("keyword") |
|
Thanks @costin, I'll have to iterate on this, so I'll include your suggestions in next batch |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and enable
GenerativeIT, test that generates and executes random ES|QL queries on the sample csv-spec datasets.For now the test considers a list of errors as acceptable (known bugs/limitations).