Skip to content

[main] Move system indices migration to migrate plugin #125437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexey-ivanov-es
Copy link
Contributor

It seems the best way to fix #122949 is to use existing data stream reindex API. However, this API is located in the migrate x-pack plugin. This commit moves the system indices migration logic (REST handlers, transport actions, and task) to the migrate plugin.

Port of #123551

It seems the best way to fix elastic#122949 is to use existing data stream reindex API. However, this API is located in the migrate x-pack plugin. This commit moves the system indices migration logic (REST handlers, transport actions, and task) to the migrate plugin.

Port of elastic#123551
@alexey-ivanov-es alexey-ivanov-es requested review from a team as code owners March 21, 2025 19:02
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 labels Mar 21, 2025
@alexey-ivanov-es
Copy link
Contributor Author

The difference with the original PR is changes to MetadataTests - new tests related to the system indices migration task are moved to SystemIndexMigrationMetadataTests in the migrate plugin

@alexey-ivanov-es alexey-ivanov-es added :Core/Infra/Core Core issues without another label >refactoring and removed needs:triage Requires assignment of a team area label labels Mar 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 21, 2025
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Apr 4, 2025
Copy link
Contributor

@JVerwolf JVerwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-ivanov-es alexey-ivanov-es merged commit fd7efe5 into elastic:main Apr 4, 2025
18 checks passed
@alexey-ivanov-es alexey-ivanov-es deleted the move-system-indices-migration_main branch April 4, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >refactoring serverless-linked Added by automation, don't add manually Team:Core/Infra Meta label for core/infra team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System data streams are not being upgraded in the feature migration API
3 participants