Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable SIMD operations on JDK 24 #125484

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Re-enable SIMD operations on JDK 24 #125484

merged 1 commit into from
Mar 24, 2025

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Mar 24, 2025

Update the check for the vector API to use SIMD operations on JDK 24

@thecoop thecoop added >non-issue blocker auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search v9.0.0 v8.18.1 v9.1.0 labels Mar 24, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Mar 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@thecoop thecoop requested a review from a team March 24, 2025 11:32
@thecoop thecoop added v9.0.1 and removed v9.0.0 labels Mar 24, 2025
benwtrent
benwtrent approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. We should be covered in our tests as well.

@thecoop thecoop merged commit da9ed5a into elastic:main Mar 24, 2025
17 checks passed
@thecoop thecoop deleted the jdk-24-simd-ops branch March 24, 2025 13:13
@thecoop thecoop mentioned this pull request Mar 24, 2025
Merged
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (elastic#125484)
5e2440d
This was referenced Mar 24, 2025
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 9.0
✅ 8.17
✅ 8.16

thecoop added a commit to thecoop/elasticsearch that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (elastic#125484)
f8805a3
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (elastic#125484)
6b29663
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (elastic#125484)
b80c935
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (#125484) (#125492)
4a5494d
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (#125484) (#125493)
d92a46b
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (#125484) (#125495)
e3ab0e6
elasticsearchmachine pushed a commit that referenced this pull request Mar 24, 2025
@thecoop
Re-enable SIMD operations on JDK 24 (#125484) (#125494)
dd3b980
ChrisHegarty
ChrisHegarty reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(belated) LGTM

omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@thecoop @omricohenn
Re-enable SIMD operations on JDK 24 (elastic#125484)
c9affeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty left review comments

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged blocker >non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.16.7 v8.17.5 v8.18.1 v9.0.1 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecoop @elasticsearchmachine @benwtrent @ChrisHegarty