Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a breaking change note for non-detailed errors #125485

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Mar 24, 2025

#90529 (comment) - add a release note about the change

@thecoop thecoop added >docs General docs changes :Core/Infra/Core Core issues without another label v9.0.0 labels Mar 24, 2025
@thecoop thecoop requested a review from a team March 24, 2025 11:49
Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@elasticsearchmachine elasticsearchmachine added v9.0.1 Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels Mar 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop thecoop requested a review from samxbr March 25, 2025 15:35
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but won't this be lost in case docs are re-generated?

@thecoop
Copy link
Member Author

thecoop commented Mar 27, 2025

This is where the breaking changes are recorded. I don't know what's going to happen with the change to md, but if it's alongside all the other release notes then it's in the right place now.

@thecoop thecoop merged commit 8eea762 into elastic:9.0 Mar 27, 2025
5 of 6 checks passed
@thecoop thecoop deleted the exception-json-bwc branch March 27, 2025 11:37
@brianseeders
Copy link
Contributor

@thecoop, @mosche is right. There needs to be a change in docs/changelog/90529.yaml for this. The asciidoc that you modified gets auto-generated from the yaml files, so your change will get blown away.

@leemthompo
Copy link
Contributor

These files are being migrated to Markdown, and any changes merged now will be lost.

The warning is not lying 😄. No asciidoc pages are being published anymore for 9.0/main so this PR will have no effect. There shouldn't even be any asciidoc files on the 9.0 branch TBH.

FYI we shouldn't be editing any asciidoc on any version branch higher than 8.x, and as Brian mentioned the changelog yaml file will ensure this change gets picked up when the release notes are being generated.

@rjernst
Copy link
Member

rjernst commented Apr 2, 2025

There shouldn't even be any asciidoc files on the 9.0 branch TBH.

I opened #126120 to address that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v9.0.0 v9.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants