-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a breaking change note for non-detailed errors #125485
Conversation
Warning It looks like this PR modifies one or more |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but won't this be lost in case docs are re-generated?
This is where the breaking changes are recorded. I don't know what's going to happen with the change to md, but if it's alongside all the other release notes then it's in the right place now. |
The warning is not lying 😄. No asciidoc pages are being published anymore for 9.0/main so this PR will have no effect. There shouldn't even be any asciidoc files on the 9.0 branch TBH. FYI we shouldn't be editing any asciidoc on any version branch higher than 8.x, and as Brian mentioned the changelog yaml file will ensure this change gets picked up when the release notes are being generated. |
I opened #126120 to address that. |
#90529 (comment) - add a release note about the change