Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ILMHistoryItemTests.testTruncateLongError #125814

Merged

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Mar 27, 2025

It should work independent of how many characters are truncated now.

Resolves #125216

It should work independent of how many characters are truncated now.

Resolves elastic#125216
@dakrone dakrone added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.19.0 v9.1.0 labels Mar 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Mar 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Mar 27, 2025
@elasticsearchmachine elasticsearchmachine merged commit de4994d into elastic:main Mar 27, 2025
17 checks passed
@dakrone dakrone deleted the fix-history-truncated-test branch March 27, 2025 22:56
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125814

@dakrone
Copy link
Member Author

dakrone commented Mar 27, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Mar 27, 2025
It should work independent of how many characters are truncated now.

Resolves elastic#125216

(cherry picked from commit de4994d)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
It should work independent of how many characters are truncated now.

Resolves #125216

(cherry picked from commit de4994d)

# Conflicts:
#	muted-tests.yml
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
It should work independent of how many characters are truncated now.

Resolves elastic#125216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ILMHistoryItemTests testTruncateLongError failing
3 participants