Skip to content

Fix testStopQueryLocal - always use the same client (same node) #131253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2025
Merged

Fix testStopQueryLocal - always use the same client (same node) #131253

merged 4 commits into from
Jul 15, 2025
+10 −9

Conversation

smalyshev
Copy link
Contributor

No description provided.

@smalyshev smalyshev force-pushed the fix-stop-query-local branch from b29bc1b to c93b1fe Compare July 15, 2025 00:05
@smalyshev smalyshev requested a review from dnhatn July 15, 2025 00:06
@smalyshev smalyshev added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL labels Jul 15, 2025
@smalyshev smalyshev marked this pull request as ready for review July 15, 2025 00:08
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

dnhatn
dnhatn approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Stas!

@smalyshev smalyshev added auto-backport Automatically create backport pull requests when merged v9.0.1 v8.9.1 labels Jul 15, 2025
@smalyshev smalyshev enabled auto-merge (squash) July 15, 2025 00:24
@smalyshev smalyshev added v8.19.1 and removed v8.9.1 labels Jul 15, 2025
@smalyshev smalyshev merged commit bfab88c into elastic:main Jul 15, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131253

@smalyshev smalyshev added v9.1.1 and removed v9.0.1 labels Jul 15, 2025
@smalyshev smalyshev mentioned this pull request Jul 15, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 15, 2025
@smalyshev
Fix testStopQueryLocal - always use the same client (same node) (elas…
f97083d 
…tic#131253)

(cherry picked from commit bfab88c)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryStopIT.java
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 15, 2025
@smalyshev
Fix testStopQueryLocal - always use the same client (same node) (elas…
5f2840f 
…tic#131253)

(cherry picked from commit bfab88c)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryStopIT.java
@smalyshev smalyshev mentioned this pull request Jul 15, 2025
Merged
@smalyshev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

@smalyshev smalyshev mentioned this pull request Jul 15, 2025
Open
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@smalyshev
[9.1] Fix testStopQueryLocal - always use the same client (same node) (…
3f1af89 
…#131253) (#131311)

* Fix testStopQueryLocal - always use the same client (same node) (#131253)

(cherry picked from commit bfab88c)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryStopIT.java

* Fix merge
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@smalyshev
Fix testStopQueryLocal - always use the same client (same node) (#131253
d45e59c 
) (#131312)

(cherry picked from commit bfab88c)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryStopIT.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.1 v9.1.1 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smalyshev @elasticsearchmachine @dnhatn