-
Notifications
You must be signed in to change notification settings - Fork 861
Update Emotion to 11.14 #8992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tkajtoch
wants to merge
10
commits into
elastic:main
Choose a base branch
from
tkajtoch:build/upgrade-emotion-to-11.14
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update Emotion to 11.14 #8992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attern and provide needed uniqueness
…yle label caused by changes to @emotion/babel-plugin
…mitting duplicated spaces
Collaborator
💚 Build Succeededcc @tkajtoch |
Collaborator
💔 Build Failed
Failed CI Stepscc @tkajtoch |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
PRs that update a dependency file
stale-pr
(Don't delete - used for automation)
tech debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Emotion packages to the latest versions. This update is supposed to increase performance in test environments thanks to changes like this one and others. It also
Why are we making this change?
@dgieselaar has found that updating Emotion to 11.12 or up helps reduce unit test time in Kibana. There's no reason not to update EUI first and test it all in action, locally and in CI.
Impact to users
There might be a minimal impact to users due to a few type updates. I'll confirm that before marking this PR as ready for review.
QA
Remove or strikethrough items that do not apply to your PR.
General checklist