-
Notifications
You must be signed in to change notification settings - Fork 861
[Icon] Adding the agentBuilderRobot icon to EUI #9259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mgadewoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoseLuisGJ Thanks for adding the new icon! 🎉
I left a couple small comments.
ℹ️ Please also always make sure to fill out the PR description appropriately. For this PR I went ahead and filled out the missing sections for you.
| @@ -1,4 +1,24 @@ | |||
| [ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be added here, the changelogs are only generated on release.
Let's revert the changes to i18ntokens.json and i18ntokens_changelog.json.
@tkajtoch Just to confirm: Nothing changed for this with new release workflow, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing this @mgadewoll . These i18n changes were made automatically and it's true it should be there related to this PR. Let me know if I've to revert the changes on these 2 files manually or if there is any i18m task I can use for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik, these changes only appear if you run yarn build. In your case, those likely were built when you ran the EUI docs locally as the build:workspaces script runs build in eui.
We can revert them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgadewoll nothing changed, it's just as you described. We could possibly find a way to only generate i18ntokens in CI now that we use it for releases. I'll think about it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkajtoch Oki, thank you for the confirmation! 🙏
Co-authored-by: Lene Gadewoll <[email protected]>
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
Summary
As described in this issue #9256 the Agent Builder Robot icon is hardcoded in the Elasticsearch and Agent Builder solutions. Due to it's having a heavy usage this one should become part of EUI
Why are we making this change?
✨ Feature: Adding a new
productRoboticon to provide a common source of truth for product usage.Screenshots #
Impact to users
🟢 No updates required. This is a new feature.
QA
General checklist
@defaultif default values are missing) and playground toggles