Skip to content

Conversation

@JoseLuisGJ
Copy link
Contributor

@JoseLuisGJ JoseLuisGJ commented Dec 4, 2025

Summary

As described in this issue #9256 the Agent Builder Robot icon is hardcoded in the Elasticsearch and Agent Builder solutions. Due to it's having a heavy usage this one should become part of EUI

Why are we making this change?

✨ Feature: Adding a new productRobot icon to provide a common source of truth for product usage.

Screenshots #

Screenshot 2025-12-05 at 10 51 37

Impact to users

🟢 No updates required. This is a new feature.

QA

  • verify the icon is available (confirm e.g. with Storybook and EUI docs)

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@JoseLuisGJ JoseLuisGJ requested a review from a team as a code owner December 4, 2025 11:35
@JoseLuisGJ JoseLuisGJ linked an issue Dec 4, 2025 that may be closed by this pull request
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoseLuisGJ Thanks for adding the new icon! 🎉
I left a couple small comments.

ℹ️ Please also always make sure to fill out the PR description appropriately. For this PR I went ahead and filled out the missing sections for you.

@@ -1,4 +1,24 @@
[
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be added here, the changelogs are only generated on release.
Let's revert the changes to i18ntokens.json and i18ntokens_changelog.json.

@tkajtoch Just to confirm: Nothing changed for this with new release workflow, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this @mgadewoll . These i18n changes were made automatically and it's true it should be there related to this PR. Let me know if I've to revert the changes on these 2 files manually or if there is any i18m task I can use for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik, these changes only appear if you run yarn build. In your case, those likely were built when you ran the EUI docs locally as the build:workspaces script runs build in eui.
We can revert them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgadewoll nothing changed, it's just as you described. We could possibly find a way to only generate i18ntokens in CI now that we use it for releases. I'll think about it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkajtoch Oki, thank you for the confirmation! 🙏

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiIcon] Add the Agent Builder icon to EUI Borealis

4 participants