Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Conversation

theanotherwise
Copy link

@theanotherwise theanotherwise commented Nov 16, 2022

Changes:

  • Fix indent for a table of values in README.md because topologySpreadConstraints is long string
  • Added topologySpreadConstraints in logstash/templates/statefulset.yaml file
  • Added test for topologySpreadConstraints in logstash/tests/logstash_test.py file
  • Fix indent for tolerations in logstash/templates/statefulset.yaml file

References:

Stakeholders:

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link

@cdenneen cdenneen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theanotherwise
Copy link
Author

theanotherwise commented Nov 17, 2022

@cdenneen sorry, i clicked by mistake re-review

@jgregmac
Copy link

Could someone with write access please review and approve? This is a really useful addition to the Logstash Helm chart.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants