-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Added mapping for actor and target entity id, related.entity #224483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8a24d97
Added mapping for actor and target entity id, related.entity
kfirpeled 98f2ceb
fix jest tests
kfirpeled a3db648
fix tests
kfirpeled 7254e95
Update x-pack/platform/test/alerting_api_integration/spaces_only/test…
kfirpeled 318db3a
add auto generated updates
kfirpeled ae8ff27
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 21cc8f2
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 74420bf
Moved actor and target fields to be only part of security's alert
kfirpeled adc10bd
fix tests
kfirpeled 9a8d4b6
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 106635f
updated generated schemas
kfirpeled 1ef6253
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled ffc9f2b
Moved related.entity to security's alerts only
kfirpeled cfbb11e
updated generated files
kfirpeled 091b849
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 4936cfe
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 1e689a8
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled e5dbff0
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 13d408c
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled 56f1066
Merge branch 'main' into cspm/alerts-mapping-update
kfirpeled File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
.../shared/alerting/server/integration_tests/__snapshots__/alert_as_data_fields.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
x-pack/solutions/security/plugins/security_solution/common/field_maps/9.2.0/alerts.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { alertsFieldMap8190 } from '../8.19.0'; | ||
import { ACTOR_ENTITY_ID, RELATED_ENTITY, TARGET_ENTITY_ID } from '../field_names'; | ||
|
||
export const alertsFieldMap920 = { | ||
...alertsFieldMap8190, | ||
/** | ||
* Part of audit logs fields that are now processed. These fields helps us present alerts and logs in a graphical way. | ||
* Both actor and target fields are a work in progress to become part of ECS. | ||
* Right now, these fields are only relevant for security's alerts and audit logs. Therefore, we add them here. | ||
*/ | ||
[ACTOR_ENTITY_ID]: { | ||
type: 'keyword', | ||
array: true, | ||
required: false, | ||
}, | ||
[RELATED_ENTITY]: { | ||
type: 'keyword', | ||
array: true, | ||
required: false, | ||
}, | ||
[TARGET_ENTITY_ID]: { | ||
type: 'keyword', | ||
array: true, | ||
required: false, | ||
}, | ||
} as const; | ||
|
||
export type AlertsFieldMap920 = typeof alertsFieldMap920; |
9 changes: 9 additions & 0 deletions
9
x-pack/solutions/security/plugins/security_solution/common/field_maps/9.2.0/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
export type { AlertsFieldMap920 } from './alerts'; | ||
export { alertsFieldMap920 } from './alerts'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that correct to import from 8.19? or should I've imported from earlier release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, given that the new mappings are always based on those of the previous release.