Skip to content

Conversation

@momovdg
Copy link
Contributor

@momovdg momovdg commented Nov 18, 2025

Summary

resolves: #243456

The flyout for 'create control' from the esql editor is not closing when clicking on the 'X' button. This PR address that bug and also incorporates this button to the telemetry tracking as a property when cancelling the creation of a control.

EDIT: as an extra fix this pr addresses a small bug around telemetry when we click on save for a control on edit mode.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@momovdg momovdg self-assigned this Nov 19, 2025
@momovdg momovdg added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.3.0 labels Nov 19, 2025
@momovdg momovdg marked this pull request as ready for review November 19, 2025 11:26
@momovdg momovdg requested a review from a team as a code owner November 19, 2025 11:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for the effort! But I think if we follow a simpler path will be better

@momovdg momovdg requested a review from a team as a code owner November 19, 2025 15:43
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanx for solving both in one

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 673.4KB 673.6KB +182.0B
esql 579.4KB 585.5KB +6.1KB
total +6.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esql 18.4KB 18.5KB +90.0B
kbnUiSharedDeps-srcJs 4.0MB 4.0MB +36.0B
total +126.0B

History

cc @momovdg

@momovdg momovdg merged commit 53b41da into elastic:main Nov 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ES|QL] Fix 'close' button on create control flyout

4 participants