-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ES|QL] Create control flyout close button bug #243365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Create control flyout close button bug #243365
Conversation
src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx for the effort! But I think if we follow a simpler path will be better
src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/esql/public/triggers/esql_controls/esql_control_action.ts
Outdated
Show resolved
Hide resolved
stratoula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanx for solving both in one
src/platform/plugins/shared/esql/public/triggers/esql_controls/esql_control_action.ts
Outdated
Show resolved
Hide resolved
…/esql_control_action.ts Co-authored-by: Stratou <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @momovdg |
Summary
resolves: #243456
The flyout for 'create control' from the esql editor is not closing when clicking on the 'X' button. This PR address that bug and also incorporates this button to the telemetry tracking as a property when cancelling the creation of a control.
EDIT: as an extra fix this pr addresses a small bug around telemetry when we click on save for a control on edit mode.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.