[9.2] Storage adapter: Propagate bulk errors (#242901) #243372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `bulk` method of the storage adapter is not failing if one of the operations fails. This can hide problems, e.g. if saving a stream would cause the `create` operation in the bulk call to fail, it would fail silently and tell the user saving worked fine. With the change on this PR, the error is passed back to the user correctly (had to mess with the mappings of the index to provoke an error, not sure whether it can be triggered accidentally): <img width="309" height="492" alt="Screenshot 2025-11-13 at 14 08 36" src="https://github.com/user-attachments/assets/aaba6185-23e3-475f-9545-fd595b5557e2" /> This is a breaking change of the storage adapter interface, but judging from the current usages we don't want this kind of error silently being ignored - throwing an error makes sure the problem is visible. (cherry picked from commit 4e7c4f9)
miltonhultgren
approved these changes
Nov 18, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation