Skip to content

[One Workflow] Render icons from registry #243388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 19, 2025
Merged

[One Workflow] Render icons from registry #243388

merged 7 commits into from
Nov 19, 2025

Conversation

@semd
Copy link
Contributor

@semd semd commented Nov 18, 2025

Summary

Retrieve connector icons from the actionTypeRegistry instead of doing cross-plugin import.

Benefits

  • Adds support for connectorsV2 icons dynamically
  • We keep the action registry as the single source of truth for the rest of connectors

Screenshots

Captura de pantalla 2025-11-18 a les 17 18 15 Captura de pantalla 2025-11-18 a les 17 18 35 Captura de pantalla 2025-11-18 a les 17 18 26 Captura de pantalla 2025-11-18 a les 17 18 09 Captura de pantalla 2025-11-18 a les 17 22 21
Captura de pantalla 2025-11-18 a les 17 20 49 Captura de pantalla 2025-11-18 a les 17 20 44 Captura de pantalla 2025-11-18 a les 17 20 40 Captura de pantalla 2025-11-18 a les 17 19 26 Captura de pantalla 2025-11-18 a les 17 19 20

@semd semd self-assigned this Nov 18, 2025
@semd semd requested a review from a team as a code owner November 18, 2025 16:23
@semd semd added the release_note:skip Skip the PR/issue when compiling release notes label Nov 18, 2025
@semd semd requested a review from a team as a code owner November 18, 2025 16:23
@semd semd added backport:skip This PR does not require backporting Team:One Workflow Team label for One Workflow (Workflow automation) labels Nov 18, 2025
adcoelho
adcoelho approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response-ops OK

@semd semd enabled auto-merge (squash) November 19, 2025 10:13
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 19, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackConnectors 419 418 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
workflowsManagement 2.1MB 2.1MB +24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 76.3KB 72.0KB -4.3KB
workflowsManagement 6.5KB 6.4KB -157.0B
total -4.5KB

History

cc @semd

@semd semd requested a review from shahargl November 19, 2025 11:35
shahargl
shahargl approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@semd semd merged commit d29ff9b into elastic:main Nov 19, 2025
12 checks passed
@delanni delanni mentioned this pull request Nov 19, 2025
Merged
delanni added a commit that referenced this pull request Nov 19, 2025
@delanni
fix project ref removal (#243537)
41d23aa 
## Summary
#243388 started to break on main's
on-merge pipeline, probably due to a merge race condition.
@semd semd mentioned this pull request Nov 19, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adcoelho adcoelho adcoelho approved these changes

@shahargl shahargl shahargl approved these changes

Assignees

@semd semd

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:One Workflow Team label for One Workflow (Workflow automation) v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@semd @elasticmachine @adcoelho @shahargl @kibanamachine