-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[SLO] Enable observed value and objective for slo details history view #243393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbelastic
wants to merge
10
commits into
elastic:main
Choose a base branch
from
sbelastic:229435-enable-observed-value-for-slo-details-history-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+835
−122
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5a2cdec
Enable observed value for slo details history view and tests
sbelastic af8057f
Cleanup redudant tests
sbelastic 90fa6b4
Merge branch 'main' into 229435-enable-observed-value-for-slo-details…
sbelastic 2f889c8
Code cleanup
sbelastic ba4af41
Merge branch 'main' into 229435-enable-observed-value-for-slo-details…
sbelastic e2ad7d6
Cleanup extra useMemo
sbelastic 53acef7
Fix broken tests and remove tests that are no longer needed
sbelastic cc7c1aa
Hide label of duration in history page
sbelastic ac576fa
Merge branch 'main' into 229435-enable-observed-value-for-slo-details…
sbelastic 3057b7f
Merge branch 'main' into 229435-enable-observed-value-for-slo-details…
sbelastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
...ck/solutions/observability/plugins/slo/public/pages/slo_details/components/base_chart.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { EuiFlexItem } from '@elastic/eui'; | ||
| import React, { type ReactNode } from 'react'; | ||
| import type { SLOWithSummaryResponse } from '@kbn/slo-schema'; | ||
| import type { ChartData } from '../../../typings/slo'; | ||
| import type { TimeBounds } from '../types'; | ||
| import { WideChart } from './wide_chart'; | ||
|
|
||
| type ChartType = 'area' | 'line'; | ||
| type State = 'success' | 'error'; | ||
|
|
||
| export interface BaseChartProps { | ||
| data: ChartData[]; | ||
| isLoading: boolean; | ||
| slo: SLOWithSummaryResponse; | ||
| onBrushed?: (timeBounds: TimeBounds) => void; | ||
| chartType: ChartType; | ||
| chartId: string; | ||
| metadata?: ReactNode; | ||
| } | ||
|
|
||
| export function BaseChart({ | ||
| data, | ||
| isLoading, | ||
| slo, | ||
| chartType, | ||
| chartId, | ||
| metadata, | ||
| onBrushed, | ||
| }: BaseChartProps) { | ||
| const isSloFailed = slo.summary.status === 'DEGRADING' || slo.summary.status === 'VIOLATED'; | ||
| const state: State = isSloFailed ? 'error' : 'success'; | ||
|
|
||
| return ( | ||
| <> | ||
| {metadata} | ||
|
|
||
| <EuiFlexItem> | ||
| <WideChart | ||
| chart={chartType} | ||
| id={chartId} | ||
| state={state} | ||
| data={data} | ||
| isLoading={isLoading} | ||
| onBrushed={onBrushed} | ||
| slo={slo} | ||
| /> | ||
| </EuiFlexItem> | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.