[7.x] [lens] Use top nav in Lens app (#46190) #47238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [lens] Use top nav in Lens app * Add tests for saved query, pass filters around more places * Fix filter passing * Add unit test for field popover making correct queries * Respond to review feedback * Fix type errors * Respond to all review comments * Remove commented code * Top nav should be compatible as angular directive * Fix rendering issue with filter updates * Respond to review comments and add onChange test * Add specific test for the index pattern bug from Tina
💔 Build Failed |
|
retest |
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
|
@lizozom @TinaHeiligers I can't figure out why these tests are failing. They work for me locally. |
|
@elasticmachine merge upstream |
|
The failing tests appear to be Discover search request timeouts.
Christiane (Tina) Heiligers
…On Thu, Oct 3, 2019 at 2:22 PM Wylie Conlon ***@***.***> wrote:
@elasticmachine <https://github.com/elasticmachine> merge upstream
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47238?email_source=notifications&email_token=AC23SSSU733LLTEGFRPMEVDQMZPCHA5CNFSM4I5ETWX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAJUOAA#issuecomment-538134272>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC23SSWS6PXKZQY76VI74PLQMZPCHANCNFSM4I5ETWXQ>
.
|
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: