genai-function-calling: update spring-ai to 1.0.0-M7 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
Contributor
Author
|
@ThomasVitale I also noticed there aren't any spans for the tool calls (the GET should be under a span representing the tool called). Am I missing something, or is it a TODO, or an expectation for programmatic code? |
anuraaga
approved these changes
Apr 12, 2025
Signed-off-by: Adrian Cole <[email protected]>
Contributor
Author
|
rejigged most work arounds into yaml so it is less distracting at the next conference |
Signed-off-by: Adrian Cole <[email protected]>
| # Right now, we cannot select azure or openai with a single property. | ||
| # See https://github.com/spring-projects/spring-ai/issues/2712 | ||
| model: | ||
| embedding: ${spring.ai.model.chat} |
Contributor
Author
There was a problem hiding this comment.
so, for now, I'm re-using the chat value for the others that have auto-configuration depenedencies despite being used. At some point I think the word "model" shouldn't be used as these are inference providers, not models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code needed to make 1.0.0-M7 work, which was more tricky than before and tracked upstream in spring-projects/spring-ai#2712 cc @ThomasVitale
Ran with ollama (over openai) and azure