-
Notifications
You must be signed in to change notification settings - Fork 31
genai-function-calling: uses OpenInference to propagate trace IDs over mcp stdio #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4f112bb
genai-function-calling: uses OpenInference to propagate trace IDs ove…
codefromthecrypt 3a0bd97
more
codefromthecrypt ec03ebf
works but only explicitly
codefromthecrypt 3de0d70
revert esm
codefromthecrypt a143b7a
put back edot
codefromthecrypt 113ff2d
import regardless of cjs
codefromthecrypt a5719d7
revise instructions
codefromthecrypt 79e006c
all good
codefromthecrypt b62515f
--import even though cjs
codefromthecrypt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { MCPInstrumentation } from "@arizeai/openinference-instrumentation-mcp"; | ||
| import * as MCPClientModule from "@modelcontextprotocol/sdk/client/index.js"; | ||
| import * as MCPServerModule from "@modelcontextprotocol/sdk/server/index.js"; | ||
|
|
||
| const mcpInstrumentation = new MCPInstrumentation(); | ||
| // MCP must be manually instrumented as it doesn't have a traditional module structure | ||
| mcpInstrumentation.manuallyInstrument({ | ||
| clientModule: MCPClientModule, | ||
| serverModule: MCPServerModule, | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.