genai-function-calling: refactors to keep mcp related code in a single file #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e file Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Apr 26, 2025
Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before was fine, just I would like to have less code in the main.py for scrolling in a presentation.
@anuraaga seems like there are a lot of sharp edges in opentelemetry-instrument and process management. I would love to get rid of these comments for an issue that defines the same, either in otel upstream or EDOT, even if that ends up closed out. If you have time to catalog it fully, please delete most of the context here for a comment that defers to that issue being solved. For now, I can see that these lines are needed, and ack self-spawning is an edge case, but it does betray simplicity ;)