Added args -v and -esonly + test refactor #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeraa
approved these changes
Feb 20, 2025
README.md
Outdated
| @@ -40,6 +40,38 @@ This script creates an `elastic-start-local` folder containing: | |||
| - `start.sh` and `stop.sh`: Scripts to start and stop Elasticsearch and Kibana | |||
| - `uninstall.sh`: The script to uninstall Elasticsearch and Kibana | |||
|
|
|||
| ### Select the version to install | |||
|
|
|||
| By default, `stat-local` uses the latest stable version of Elastic stack. If you want, you can specify | |||
There was a problem hiding this comment.
start-local misses an R. Also Stack with a capital S would IMO be preferred.
| as follows: | ||
|
|
||
| ```bash | ||
| curl -fsSL https://elastic.co/start-local | sh -s -- -esonly |
There was a problem hiding this comment.
More of a random thought: Should we introduce the concept of a "profile"? Like esonly but there could also be security, otel, observability,... Maybe going too far — we can keep it as a thought for a future refactoring.
There was a problem hiding this comment.
Yes, that's the idea for future options, like o11y, security, genai, etc. These options will change the docker-compose configuration and enabling by default some settings, like the ELSER for genai, etc. We'll discuss more about this in the next days.
|
Thanks @xeraa for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following options to
start-local.shscript:-v <version>, where<version>is the Elasticsearch (and Kibana) version to be installed.-esonly, install only Elasticsearch, without Kibana.By default, the
start-local.shscript uses the latest stable version of Elastic stack. To use the-voption, you can use the following command:curl -fsSL https://elastic.co/start-local | sh -s -- -v 9.0.0-beta1For instance, the previous command installs the
9.0.0-beta1version.The other option,
-esonlycan be used to install only Elasticsearch, without Kibana:curl -fsSL https://elastic.co/start-local | sh -s -- -esonlyYou can also mix the parameters, for instance install only Elasticsearch with a specific version (e.g. 8.16.0), as follows:
curl -fsSL https://elastic.co/start-local | sh -s -- -v 8.16.0 -esonlyThis PR includes also a refactor of the tests, adding two specific tests for the
-vand-esonlyoptions.