feat(proxy): synthetics cli proxy support #1044
Conversation
emilioalvap
requested review from
mcapell,
shahzad31,
vigneshshanmugam and
redcinelli
emilioalvap
changed the title
|
Working on unit test rn |
|
@mcapell @vigneshshanmugam This is ready for review |
src/options.ts
Outdated
| try { | ||
| return readFileSync(filePath); | ||
| } catch (e) { | ||
| throw new Error(`could not be read provided path ${filePath}: ${e}`); |
There was a problem hiding this comment.
nit: Can we keep the error specific to proxy settings.
There was a problem hiding this comment.
Added the flag the error applies to, this is generic to any file-based option so I don't think it makes sense to restrict this only to proxy settings?
|
Hi Team, |
| ) | ||
| .option( | ||
| '--proxy-no-verify', | ||
| 'disable TLS verification for the proxy connection', |
There was a problem hiding this comment.
does overriding NODE_TLS_UNAUTHORIZED disable this? can you callout this in the description.
There was a problem hiding this comment.
Mentioning NODE_TLS_REJECT_UNAUTHORIZED in our docs, as a featured that is strongly discouraged in nodejs docs, seems to me like would have the opposite effect and it's also inconsistent, we don't include it in our docs for Kibana TLS verification. It's not really overriding anything either, both are on by default. I'm inclined to merge it as it is and we can extend the docs if we get any corner case
|
I've tested with version 1.19.0 and seems the new code in the main is not tagged yet!!! Can someone take a look into this please? |
Summary
pushcommand #949.Add global proxy to push/locations command with:
HTTP_PROXY,HTTPS_PROXY,NO_PROXY.--proxy-uri:--proxy-token: Based in auth header format, egBasic Asaaas==--proxy-ca: Custom CA chain file or string for self-signed certificate validation. Based on nodejs TLS secure context.--proxy-cert: Custom cert chain file or string for self-signed certificate validation. Based on nodejs TLS secure context--proxy-no-verify: Disable proxy TLS verification.