Remove DynamicOneShot trait.
#19
Conversation
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
5 times, most recently
from
fe3a67a to
78aafb3
Compare
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
from
78aafb3 to
bd95c9c
Compare
|
@eldruin, rebased the PRs. |
| @@ -235,7 +235,7 @@ impl BitFlags { | |||
| } | |||
|
|
|||
| pub mod channel; | |||
| pub use channel::{ChannelId, ChannelSelection}; | |||
| pub use channel::ChannelId; | |||
There was a problem hiding this comment.
I do not think we should expose ChannelSelection publicly.
| #[doc = $doc] | ||
| $CH, | ||
| )+ | ||
| mod private { |
There was a problem hiding this comment.
Why do you move this module inside this macro?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
This way the ChannelId is sealed by making ChannelSelection private.
|
|
||
| /// Marker type for an ADC input channel. | ||
| pub trait ChannelId<T>: private::Sealed { | ||
| pub trait ChannelId<T> { |
There was a problem hiding this comment.
Why should this trait not be sealed?
There was a problem hiding this comment.
It is actually sealed since the ChannelSelection type is private.
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
from
d796952 to
dad963e
Compare
reitermarkus
force-pushed
the
remove-dynamic-one-shot
branch
from
dad963e to
4f46a6e
Compare
|
@eldruin, can you have another look here? Thanks. |
|
@eldruin, please review this again. Thanks. |
There was a problem hiding this comment.
Sorry for the delay @reitermarkus. Thank you for your work.
From reading #10 (comment), it looks like adding this trait didn't actually solve the issue.
Depending on the device, this also allows reading invalid channels.