Use maybe-async-cfg to add async support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-van-zuijlen
force-pushed
the
maybe-async
branch
3 times, most recently
from
d11b4a3 to
61ced96
Compare
eldruin
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Awesome work, thank you!
I just added a couple of nitpicks.
Could you also update the MSRV in the README to 1.75.0?
Sorry, I had to do a couple of fixes due to clippy failing. Could you rebase this?
We can look into making the embassy example compile after merging this.
Maybe it is worth adding a whole example subfolder inside the examples folder with all the embassy stuff instead of adding them to the main crate.
NOTE TO SELF: Add rule to release.toml to update crate version in the README and in the lib.rs
nils-van-zuijlen
force-pushed
the
maybe-async
branch
from
61ced96 to
9bfa2aa
Compare
|
Thank you for your help and guidance! |
|
I have published this in version 1.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #14 , #13
Also, update to embedded-hal v1 so that there is only one trait for I2C on both sides.
Closes #15
Closes #11
Heavily inspired by eldruin/tcs3472-rs#5
I could not make the example in
lib.rscompile, even when adding the embassy dependencies, because I cannot figure out how to enable a feature for a single doctest. So I did not include the embassy deps.