Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Commit

Permalink
Merge pull request #78 from electric-cloud/ECPLUGINS-15
Browse files Browse the repository at this point in the history
Fix creating configuration by user with "@" in username
justnoxx authored Mar 11, 2019
2 parents 2b61e56 + e01cba9 commit bd67f1e
Showing 3 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ buildscript {
group = "com.electriccloud"
description = "Plugins : EC-EC2"

version = "2.5.2"
version = "2.5.3"

apply plugin: 'groovy'
apply plugin: 'flow-gradle-plugin'
6 changes: 5 additions & 1 deletion pages/EC-EC2_help.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
<p>Plugin Version @PLUGIN_VERSION@</p>
<hr style="margin-left: -10px; margin-top: 10px; height: 1px; width: 100%; color: #5981BD;" noshade="noshade" />

<p>Revised on September 20, 2018</p>
<p>Revised on March 06, 2019</p>

<h1>Contents</h1>

@@ -2463,6 +2463,10 @@
</div>

<h1 id="rns">Release Notes</h1>
<h2>@PLUGIN_KEY@ 2.5.3</h2>
<ul>
<li>Configurations can be created by users with "@" sign in a name.</li>
</ul>
<h2>@PLUGIN_KEY@ 2.5.2</h2>
<ul>
<li>Proxy credentials are now removed when configuration is deleted.</li>
4 changes: 2 additions & 2 deletions src/main/resources/project/conf/createAndAttachCredential.pl
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@
my $password = $xpath->findvalue("//password");

# Create credential
my $projName = "@PLUGIN_KEY@-@PLUGIN_VERSION@";
my $projName = '@PLUGIN_KEY@-@PLUGIN_VERSION@';

$ec->deleteCredential($projName, $credName);
$xpath = $ec->createCredential($projName, $credName, $userName, $password);
@@ -73,7 +73,7 @@
$errors .= $ec->checkAllErrors($xpath);

# Give job launcher full permissions on the credential
my $user = "$[/myJob/launchedByUser]";
my $user = '$[/myJob/launchedByUser]';
$xpath = $ec->createAclEntry("user", $user, {
projectName => $projName,
credentialName => $credName,

0 comments on commit bd67f1e

Please sign in to comment.