This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Added Appveyor config for Windows CI builds #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appveyor.yml
Outdated
| environment: | ||
| matrix: | ||
| - nodejs_version: "6" | ||
| - nodejs_version: "7" |
There was a problem hiding this comment.
We could (and should IMO) save build time by only caring about latest LTS (node v6)
appveyor.yml
Outdated
| - nodejs_version: "7" | ||
|
|
||
| platform: | ||
| - x86 |
There was a problem hiding this comment.
Same here, 32bit windows is rare these days and the odds it works on one arch and not the other is quite slim. This just adds build time.
|
This runs I'm not sure how to deal with that, or if it's a problem at all. |
|
This would be nice to merge but it would require someone with access to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an Appveyor config file to let us do Windows CI builds.
Here's some example output if you're interested:
https://ci.appveyor.com/project/Mike-Dax/electron-compile