Skip to content

fix: ensures saved status only triggers if local path exists #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amrkhaled104 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensures saved status only triggers if local path exists #1825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/renderer/components/commands-action-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,12 @@ export const GistActionButton = observer(

try {
const description = await this.getFiddleDescriptionFromUser();

if (description) {
if (await this.publishGist(description)) {
await this.props.appState.editorMosaic.markAsSaved();
// Fix for #1821: Only mark as saved if we have a local path
if (appState.localPath) {
await this.props.appState.editorMosaic.markAsSaved();
}
}
}
} finally {
Expand Down Expand Up @@ -214,8 +216,9 @@ export const GistActionButton = observer(
files,
});

await appState.editorMosaic.markAsSaved();
console.log('Updating: Updating done', { gist });
if (appState.localPath) {
await appState.editorMosaic.markAsSaved();
} console.log('Updating: Updating done', { gist });

if (!silent) {
this.renderToast({
Expand Down