feat!: bump engines to Node.js 22 #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
commented
Jan 11, 2025
| d('* Replacing existing file'); | ||
| await fs.remove(cachePath); | ||
|
|
||
| if (!fs.existsSync(path.dirname(cachePath))) { |
There was a problem hiding this comment.
Note: this new clause is needed because fs.rename will fail if the target directory doesn't exist, while fs.move creates the directory.
This also doesn't work across disks, but we could catch the resulting error and fall back to an fs.copy call if necessary.
dsanders11
reviewed
Jan 15, 2025
Comment on lines
29
to
34
| "debug": "^4.1.1", | ||
| "env-paths": "^2.2.0", | ||
| "fs-extra": "^8.1.0", | ||
| "got": "^11.8.5", | ||
| "progress": "^2.0.3", | ||
| "semver": "^6.2.0", | ||
| "sumchecker": "^3.0.1" |
There was a problem hiding this comment.
Do we want to bump major versions here while we're at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: bumps minimum Node.js version to 22