Improve accessibility of toggle and checkbox menu items#377
Merged
Conversation
MenuItems can be used either inside a Menu component (which creates a roving tab index) or simply with an element of role menu. In the latter case, focus would previously land on the cosmetic <input> element, which is a bad idea as it's hidden from accessibility technologies. By turning the parent <div role="menuitemcheckbox"> into a <button> instead, we can ensure that focus always lands on the parent element. This is possible because ToggleMenuItem and CheckboxMenuItem are controlled components these days.
Deploying compound-web with
|
| Latest commit: |
55832e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05f4c93a.compound-web.pages.dev |
| Branch Preview URL: | https://toggle-accessibility.compound-web.pages.dev |
Member
Author
|
@t3chguy Are you still interested in giving this change a review? I recall you brought it up when looking at menus in Element Web, but it would also benefit Element Call. |
Member
|
@robintown can you make CI happy? |
Member
Author
|
@t3chguy Have finally done so. |
t3chguy
approved these changes
Jan 5, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
LGTM, one thing I noticed (not affected by this PR) is disabled items are not reachable by keyboard so disabled items are almost invisible to non-sighted users, if you're still in the area of improving accessibility that'd be a good one to resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuItems can be used either inside a Menu component (which creates a roving tab index) or simply with an element of role
menu. In the latter case, focus would previously land on the cosmetic<input>element, which is a bad idea as it's hidden from accessibility technologies. By turning the parent<div role="menuitemcheckbox">into a<button>instead, we can ensure that focus always lands on the parent element. This is possible because ToggleMenuItem and CheckboxMenuItem are controlled components these days.