Fix failure to request persistent storage perms #31299
Open
+145
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a whole bunch of code dedicated to attempting to force a "light" theme onto the login view, even if the deployment is configured to prioritise the dark theme. Apparently this was done because, in the old days, the login view looked rubbish with the dark theme, but now it looks fine. Fixes #31292
I think this needs to happen whether or not we are in the middle of a login flow. Fixes: #31298
It's now a one-liner, and its semantics are very confusing.
Now that we've got rid of the confusing `onLoggedIn` method, we can factor out a method which *actually* handles `OnLoggedIn` actions.
richvdh
changed the base branch from
develop
to
rav/MatrixChat_documentation
dbkr
approved these changes
Nov 21, 2025
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
lgtm as long as the login dark theme stuff is okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we call
tryPersistStorageduring a login flow. Fixes #31298.Also some refactoring. Review commit-by-commit.
Based on #31293 and #31297.