Skip to content

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 3, 2025

Closes #4558, depends on #4568

Simulator.Screen.Recording.-.iPhone.17.-.2025-10-03.at.15.59.01.mov

@pixlwave pixlwave requested a review from a team as a code owner October 3, 2025 14:59
@pixlwave pixlwave removed the request for review from a team October 3, 2025 14:59
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Oct 3, 2025
@pixlwave pixlwave requested a review from stefanceriu October 3, 2025 14:59
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.50%. Comparing base (b58d426) to head (a04f75e).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4571   +/-   ##
========================================
  Coverage    79.50%   79.50%           
========================================
  Files          865      865           
  Lines        81435    81435           
========================================
  Hits         64741    64741           
  Misses       16694    16694           
Flag Coverage Δ
compound 92.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from doug/leave-space to develop October 3, 2025 15:37
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, ship it! 🚀

@pixlwave pixlwave force-pushed the doug/spaces-announcement branch from 4b91200 to a04f75e Compare October 6, 2025 09:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@pixlwave
Copy link
Member Author

pixlwave commented Oct 6, 2025

CI is broken beyond belief… So yolo I guess 🤷‍♂️

@pixlwave pixlwave merged commit 93f7127 into develop Oct 6, 2025
14 of 17 checks passed
@pixlwave pixlwave deleted the doug/spaces-announcement branch October 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Inform users about the very first release of Spaces

3 participants