Replace PyICU with Rust icu_segmenter
crate
#18553
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18282.
Replaces the
PyICU
python wrapper around the C++icu
library with a native Rust solution; theicu_segmenter
crate, which is part of the broadericu
crate.This eliminates the need for downstream users to install the
libicu
package if they want to have improved user search.The model decided to use the default constructor for
WordSegmenter
, and I agree. Our "data" is the user's search query, which is always parsed on the fly and not stored. So it's OK if it changes between ICU releases.Note: This PR was mostly written by OpenAI Codex, before being reviewed by myself. Commits written by Codex are marked as those made by @anoadragon453-codex. Please use extra caution when reviewing them.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.