Skip to content

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Sep 29, 2025

Remove deprecated LoggingContext.set_current_context/LoggingContext.current_context methods

These were added for backwards compatibility (and essentially deprecated) in matrix-org/synapse#7408 (2020-05-04) because synapse-s3-storage-provider previously relied on them -- but synapse-s3-storage-provider since been updated to no longer use them.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

These were added for backwards compatibility in matrix-org/synapse#7408
@MadLittleMods MadLittleMods marked this pull request as ready for review September 29, 2025 20:00
@MadLittleMods MadLittleMods requested a review from a team as a code owner September 29, 2025 20:00
@MadLittleMods MadLittleMods merged commit 70c044d into develop Oct 2, 2025
74 of 78 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/logging-context-remove-deprecated-methods branch October 2, 2025 18:21
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @anoadragon453 🐕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants