-
-
Notifications
You must be signed in to change notification settings - Fork 115
elementary high contrast (light) stylescheme #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Putting up for review to see whether this has any legs. I have used it for a while without problem. Do we need to give option for the "classic" high contrast scheme as well? |
|
I like how it looks personally but I don't know if there are any UX concerns with it besides the contrast meeting standards |
|
Requested UX input from @danirabbit |
|
I thought it was maybe @micahilbery who did these for Terminal? Probably would have good insight |
|
@micahilbery Would you like to apply your expertise when you have time? Thanks. |
micahilbery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the direction, just a couple comments.
|
@micahilbery I've incorporated your helpful suggestion, thanks. Because the elementary palette appears less saturated than the classic one I think the theme works better with a bold font but I am not sure whether we should impose that. |
…com/elementary/code into jeremypw/custom-classic-stylescheme
Fixes #548
Based on the elementary-light theme but tweaked to produce better contrast, using the elementary palette mainly.
Preferably needs testing by a user who prefers or requires a high-contrast theme, and on as many different languages as possible. I checked on Vala, C, XML and Meson mainly.
The theme probably works better with a bold font but for comparison with "classic" below, the same regular font is used.
Comparison between "elementary-high-contrast" (on the left) and "classic" scheme (on the right)
