Move docs into another window when another one closes #1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721
For simplicity, when a second or subsequent window is closed its documents are now reopened in a remaining window. This is to ensure that the "opened-documents" setting contains all documents opened in the session and that no data is lost (even if unsaved by second window).
As a consequence of this, closing a second or subsequent window (with
<Ctrl>Qor otherwise) only closes the focused window.More complex solutions are possible, such as having multiple lists of documents in settings and restoring all the windows but refinements can be made in subsequent PRs, if required, once the correct behaviour has been decided.
NOTE: Restarting or closing down the system still causes unsaved data to be lost as in 'master'.